[ https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197080#comment-16197080 ]
Hudson commented on HBASE-18568: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #225 (See [https://builds.apache.org/job/HBase-1.3-IT/225/]) HBASE-18924 Backport HBASE-18568 (Correct metric of numRegions) to (mdrob: rev 0d836d986f04d8e6ca09774ff08db603ae34c21f) * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java > Correct metric of numRegions > ------------------------------ > > Key: HBASE-18568 > URL: https://issues.apache.org/jira/browse/HBASE-18568 > Project: HBase > Issue Type: Bug > Components: metrics > Affects Versions: 3.0.0 > Reporter: Shibin Zhang > Assignee: Shibin Zhang > Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18568-V1.patch > > > i found the value of metric numReigons in Regions is not correct. > the metric can not add or remove region correctly as region close or open. > the metric as follow: > "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions", > "numRegions" : 2, > after trouble shooting ,i found the reason is in > MetricsRegionSourceImpl#MetricsRegionSourceImpl > {code:java} > agg.register(this); > ... > hashCode = regionWrapper.getRegionHashCode(); > {code} > when add the MetricsRegionSource to set ,but the hashCode has not yet > initialized. > So, the setFromMap can not put or remove the object correctly. > it will be better like this : > {code:java} > hashCode = regionWrapper.getRegionHashCode(); > agg.register(this); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)