[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197116#comment-16197116
]
stack commented on HBASE-18957:
-------------------------------
bq. Maybe also I should update the JIRA subject to say the same?
Yeah. No harm.
For stuff like filters, no harm a comment or method javadoc saying what is
expected... Can add on commit.
Then the change in FilterList, is that part of the revert you and Peter are
talking of doing?
Thats odd, that there are two mentions of
a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java in
the patch. Am I reading it wrong? (First there is removal of some breaks, then
there is more substantial change)
> add test that establishes branch-1 behavior for filterlist w/OR and revert as
> needed to make it pass.
> -----------------------------------------------------------------------------------------------------
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Reporter: Sean Busbey
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch,
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch,
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on
> OR prior to our filterlist improvements so we have a baseline to show
> compatibility (and/or document incompatibilities that end up being
> introduced).
> Specifically (paraphrased from HBASE-18368 description): Using 2
> FamilyFilters in a FilterList using MUST_PASS_ONE operator should return
> results that match either of the FamilyFilters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
