[
https://issues.apache.org/jira/browse/HBASE-18957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197641#comment-16197641
]
Sean Busbey commented on HBASE-18957:
-------------------------------------
{quote}
bq. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace.
Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply
This looks legit. Weird that it's only on master. I'll clean this up before
pushing.
{quote}
this turned out to be in one of the reverts, so I didn't touch it.
> add test that confirms 2 FamilyFilters in a FilterList using MUST_PASS_ONE
> operator will return results that match either of the FamilyFilters and
> revert as needed to make it pass.
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18957
> URL: https://issues.apache.org/jira/browse/HBASE-18957
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Reporter: Sean Busbey
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13, 2.0.0-alpha-4
>
> Attachments: HBASE-18957-branch-1.2.v0.patch,
> HBASE-18957-branch-1.2.v1.patch, HBASE-18957-branch-1.4.v1.patch,
> HBASE-18957-branch-1.v1.patch, HBASE-18957-master.v1.patch
>
>
> we need a test that shows the expected behavior for filter lists that rely on
> OR prior to our filterlist improvements so we have a baseline to show
> compatibility (and/or document incompatibilities that end up being
> introduced).
> Specifically (paraphrased from HBASE-18368 description): Using 2
> FamilyFilters in a FilterList using MUST_PASS_ONE operator should return
> results that match either of the FamilyFilters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
