[
https://issues.apache.org/jira/browse/HBASE-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198098#comment-16198098
]
Duo Zhang commented on HBASE-18951:
-----------------------------------
{quote}
Passing a null once was supposed to signal add the value to the family w/o a
qualifier (IIRC). This was not an especially good idea. Now we'd do it with a
qualifier that is zero-byte array?
{quote}
It seems that there is no difference between a null qualifier and an empty byte
array qualifier. Let me write a test to verify it.
{quote}
i.e. you'd do this inside the checkAndXXX?
if (qualifier == null)
{ qualifier = HConstants.EMPTY_BYTE_ARRAY; }
Thats seems good to me.
{quote}
Not in this patch. It is an implementation detail and can be changed at any
time. For now I think we need to focus on the public API. We should make the
breaking changes at once. Otherwise we need to carry them for another major
release...
> Use Builder pattern to remove nullable parameters for checkAndXXX methods in
> RawAsyncTable/AsyncTable interface
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18951
> URL: https://issues.apache.org/jira/browse/HBASE-18951
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18951-v1.patch, HBASE-18951.patch
>
>
> As Optional is not supposed to be used as method parameters but we do not
> want nullable parameters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
