[
https://issues.apache.org/jira/browse/HBASE-17633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198622#comment-16198622
]
Hadoop QA commented on HBASE-17633:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-17633 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-17633 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12860636/HBASE-17633-v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9022/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Update unflushed sequence id in SequenceIdAccounting after flush with the
> minimum sequence id in memstore
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-17633
> URL: https://issues.apache.org/jira/browse/HBASE-17633
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-17633-v1.patch, HBASE-17633.patch
>
>
> Now the tracking work is done by SequenceIdAccounting. And it is a little
> tricky when dealing with flush. We should remove the mapping for the given
> stores of a region from lowestUnflushedSequenceIds, so that we have space to
> store the new lowest unflushed sequence id after flush. But we still need to
> keep the old sequence ids in another map as we still need to use these values
> when reporting to master to prevent data loss(think of the scenario that we
> report the new lowest unflushed sequence id to master and we crashed before
> actually flushed the data to disk).
> And when reviewing HBASE-17407, I found that for CompactingMemStore, we have
> to record the minimum sequence id.in memstore. We could just update the
> mappings in SequenceIdAccounting using these values after flush. This means
> we do not need to update the lowest unflushed sequence id in
> SequenceIdAccounting, and also do not need to make space for the new lowest
> unflushed when startCacheFlush, and also do not need the extra map to store
> the old mappings.
> This could simplify our logic a lot. But this is a fundamental change so I
> need sometime to implement, especially for modifying tests... And I also need
> sometime to check if I miss something.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
