[ 
https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198741#comment-16198741
 ] 

Mike Drob commented on HBASE-14093:
-----------------------------------

tab.js is not third-party code, we should go ahead and fix the whitespace there.

Why are we unpacking the webjar and then moving it to a different directory in 
two steps? Why not unpack it into the correct directory to begin with? Probably 
could add a comment to the build to explain this, there's already enough maven 
magic in the build that I don't think we need any more.

Do we still need the maven 2.2 workaround in the jar plugin? Our minimum is 
Maven 3.0.3 for a long time now.

Can we upgrade from Bootstrap 3.0.0 to something newer? The latest is 3.3.7 and 
probably has a lot of fixes and improvements.

> deduplicate copies of bootstrap files
> -------------------------------------
>
>                 Key: HBASE-14093
>                 URL: https://issues.apache.org/jira/browse/HBASE-14093
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Tamas Penzes
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14093.master.001.patch, 
> HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, 
> HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, 
> patch-shadedjars.txt
>
>
> right now we have a couple of different copies of the bootstrap js and css 
> files. It'll be easier to maintain them later if we can centralize.
> Move them to a common location and use maven to populate them as needed in 
> various component build directories.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to