[
https://issues.apache.org/jira/browse/HBASE-18951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201273#comment-16201273
]
Appy commented on HBASE-18951:
------------------------------
Was in my pipeline for review, but got delayed. Sorry for late review.
Great pattern! I like it [~Apache9].
During review, I was wondering for 10 min, there is *if* in "ifNotExists" and
"ifMatches" but i don't see any booleans/conditions anywhere :)
Thinking about it, probably something like {{setConditionValueEquals}} and
{{setConditionColumnNotExists}} would have suggested that we are just setting
conditions/requirements here. The looking at builder code, and seeing lack of
any branching (which any *if* makes us think) would have suggested that - oh,
these {{op}} and {{value}} assignments are somehow setting up params for
conditions which are evaluated later.
> Use Builder pattern to remove nullable parameters for checkAndXXX methods in
> RawAsyncTable/AsyncTable interface
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-18951
> URL: https://issues.apache.org/jira/browse/HBASE-18951
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18951-v1.patch, HBASE-18951.patch
>
>
> As Optional is not supposed to be used as method parameters but we do not
> want nullable parameters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
