[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204275#comment-16204275
]
Enis Soztutar commented on HBASE-18901:
---------------------------------------
I was able to test v5 successfully. The build goes through, and tests are
running with {{make test}} in the docker env.
Great work, +1 for the patch, but we can do these follow ups:
- target executables (xxx-test and load-client, etc) should be generated
under build/ or CMakeFiles/.
- Make test is hanging at async-batch-rpc-retrying-test for me:
{code}
root@securecluster:/usr/src/hbase/hbase-native-client# make test
Running tests...
Test project /usr/src/hbase/hbase-native-client
Start 1: append-test
1/33 Test #1: append-test ...................... Passed 0.00 sec
Start 2: async-batch-rpc-retrying-test
{code}
- Possibly break up the test files under src/test/ to be {{src/test/client}},
{{src/test/connection}}, etc.
- Hook up cmake with the general mvn build by providing a pom.xml in the
module. calling mvn compile or test with -Pnative should kick in the native
build with cmake. See Hadoop's integration for an example.
> Support build with CMake
> ------------------------
>
> Key: HBASE-18901
> URL: https://issues.apache.org/jira/browse/HBASE-18901
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: marco polo
> Labels: C++
> Fix For: HBASE-14850
>
> Attachments: HBASE-18901.v1.HBASE-14850.patch,
> HBASE-18901.v2.HBASE-14850.patch, HBASE-18901.v3.HBASE-14850.patch,
> HBASE-18901.v4.HBASE-14850.patch, HBASE-18901.v5.HBASE-14850.patch
>
>
> I've co-opted some help from folks in trying to support CMake as the build
> tool instead of Buck.
> They have something working, but need to consolidate the patch. Filing an
> issue for them to put a patch on.
> FYI [~enis], [~tedyu]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
