[ 
https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204769#comment-16204769
 ] 

stack edited comment on HBASE-18233 at 10/14/17 6:34 PM:
---------------------------------------------------------

bq. Since this change is w.r.t. locking, consider running ITBLL with change.

ITBLL does not do increment (nor any checkAndPut). Running ITBLL would not 
exercies the code path changed by this patch. [~ted_yu]

[~carp84] We've been having trouble w/ timeout on test runs. We need to dig in. 
Probably not this patch. Let me retry.

[~allan163] yes, would be cool if a report on what you see in production if you 
have this deployed.

I was waiting for a report back from the original internal customer on whether 
this patch solved their issue. Yesterday I got confirmation that in a compare, 
this patch exhibits the same performance profile as the pre-1.2 hbase under 
heavy increment loading so they are good w/ this patch. So, I'm +100 on getting 
this in.




was (Author: stack):
bq. Since this change is w.r.t. locking, consider running ITBLL with change.

ITBLL does not do increment (nor any checkAndPut). Running ITBLL would not the 
code path changed by this patch. [~ted_yu]

[~carp84] We've been having trouble w/ timeout on test runs. We need to dig in. 
Probably not this patch. Let me retry.

[~allan163] yes, would be cool if a report on what you see in production if you 
have this deployed.

I was waiting for a report back from the original internal customer on whether 
this patch solved their issue. Yesterday I got confirmation that in a compare, 
this patch exhibits the same performance profile as the pre-1.2 hbase under 
heavy increment loading so they are good w/ this patch. So, I'm +100 on getting 
this in.



> We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
> -------------------------------------------------------------------------
>
>                 Key: HBASE-18233
>                 URL: https://issues.apache.org/jira/browse/HBASE-18233
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.7
>            Reporter: Allan Yang
>            Assignee: Allan Yang
>            Priority: Blocker
>             Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7
>
>         Attachments: HBASE-18233-branch-1.2.patch, 
> HBASE-18233-branch-1.2.v2.patch, HBASE-18233-branch-1.2.v3.patch, 
> HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, 
> HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch
>
>
> Please refer to the discuss in HBASE-18144
> https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to