[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16205482#comment-16205482
]
Hadoop QA commented on HBASE-18945:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 63 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
24s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
12s{color} | {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
10s{color} | {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
16s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
22s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
12s{color} | {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
15s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
14s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
16s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
22s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 12s{color}
| {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 15s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 14s{color}
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 14s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 16s{color}
| {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 22s{color}
| {color:red} hbase-spark in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
12s{color} | {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
15s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
10s{color} | {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
14s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
14s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
16s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scalac {color} | {color:red} 0m
22s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
52s{color} | {color:red} patch has 54 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
31s{color} | {color:red} The patch causes 54 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
12s{color} | {color:red} The patch causes 54 errors with Hadoop v2.6.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
51s{color} | {color:red} The patch causes 54 errors with Hadoop v2.6.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
30s{color} | {color:red} The patch causes 54 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
10s{color} | {color:red} The patch causes 54 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
50s{color} | {color:red} The patch causes 54 errors with Hadoop v2.7.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
29s{color} | {color:red} The patch causes 54 errors with Hadoop v2.7.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
8s{color} | {color:red} The patch causes 54 errors with Hadoop v2.7.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
49s{color} | {color:red} The patch causes 54 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
12s{color} | {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
15s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
9s{color} | {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
22s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
15s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
22s{color} | {color:red} hbase-spark in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
15s{color} | {color:red} hbase-common generated 27 new + 0 unchanged - 0 fixed
= 27 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
17s{color} | {color:red} hbase-client generated 6 new + 2 unchanged - 0 fixed =
8 total (was 2) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
9s{color} | {color:red} hbase-prefix-tree generated 2 new + 0 unchanged - 0
fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} hbase-server generated 23 new + 0 unchanged - 0 fixed
= 23 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
13s{color} | {color:red} hbase-mapreduce generated 6 new + 0 unchanged - 0
fixed = 6 total (was 0) {color} |
| {color:red}-1{color} | {color:red} scaladoc {color} | {color:red} 0m
24s{color} | {color:red} hbase-spark generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 12s{color}
| {color:red} hbase-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 10s{color}
| {color:red} hbase-prefix-tree in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{color}
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 14s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 16s{color}
| {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 22s{color}
| {color:red} hbase-spark in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
52s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18945 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892332/HBASE-18945_6.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile scalac scaladoc |
| uname | Linux c8da787979fc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 83af5f2 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-common.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-client.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-prefix-tree.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-server.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-mapreduce.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-backup.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-it.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-spark.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
|
| scalac |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-common.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-client.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-prefix-tree.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-mapreduce.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-backup.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-spark.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-prefix-tree.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-mapreduce.txt
|
| scaladoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-scaladoc-scaladoc-hbase-spark.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-client.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-prefix-tree.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-backup.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-it.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-spark.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/testReport/ |
| modules | C: hbase-common hbase-client hbase-prefix-tree hbase-server
hbase-mapreduce hbase-backup hbase-it hbase-spark U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9128/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Make a Public interface for CellComparator
> ------------------------------------------
>
> Key: HBASE-18945
> URL: https://issues.apache.org/jira/browse/HBASE-18945
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18495.patch, HBASE-18945_2.patch,
> HBASE-18945_3.patch, HBASE-18945_4.patch, HBASE-18945_5.patch,
> HBASE-18945_6.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we
> expose CellComparator as a public interface so that it could be used in
> Region/Store interfaces to be exposed to CPs.
> Currently the Comparator is exposed in Region, STore and StoreFile. There is
> another discussion whether to expose it at all layers or only at Region.
> However since we are exposing this to CPs CellComparator being @Private is
> not the ideal way to do it. We have to change it to LimitedPrivate. But
> CellComparator has lot of additional methods which are internal (like where a
> Cell is compared with an incoming byte[] used in index comparsions etc).
> One way to expose is that as being done now in HBASE-18826 - by exposing the
> return type as Comparator<Cell>. But this is not powerful. It only allows to
> compare cells. So we try to expose an IA.LimitedPrivate interface that is
> more powerful and allows comparing individual cell components also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
