[
https://issues.apache.org/jira/browse/HBASE-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207081#comment-16207081
]
Lars Hofhansl commented on HBASE-15631:
---------------------------------------
Had a look at the patch posted here - assuming that's the latest.
In this round I focused on convincing myself that this would not cause existing
functionality to break.
Questions/Nits:
* ServerName.java seems to have brought HostAndPort back.
* Changes in ProtobufUtil.java seem unnecessary
* The HMaster changes look "interesting". Looks like there could be NPE
condition with regionState in the reshuffled if-statement (the original seems
more correct). And I also do not follow the unconditional call to
randomAssignment there. Are those changes needed at all?
The rest looks like net-new functionality and on the face of it looks all good,
but a full review will take some time. [~apurtell] and I will try to walk
through the code together tomorrow.
> Backport Regionserver Groups (HBASE-6721) to branch-1
> ------------------------------------------------------
>
> Key: HBASE-15631
> URL: https://issues.apache.org/jira/browse/HBASE-15631
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0
> Reporter: Francis Liu
> Assignee: Francis Liu
> Fix For: 1.4.0, 1.5.0
>
> Attachments: HBASE-15631-branch-1.patch, HBASE-15631.branch-1.patch,
> HBASE-15631.patch
>
>
> Based on dev list discussion backporting region server group should not be an
> issue as it does not: 1. destabilize the code. 2. cause backward
> incompatibility.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
