[ 
https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208341#comment-16208341
 ] 

Mike Drob commented on HBASE-18893:
-----------------------------------

Diving deeper, I want to remove AddColumnFamilyProcedure and 
DeleteColumnFamilyProcedure completely, and either delete the tests or rework 
them to test the add/delete column actions instead of testing the procedures 
directly.

I don't think there is a perf implication here because in add we end up 
building a whole new table descriptor anyway... (similar in delete)
{code}
    env.getMasterServices().getTableDescriptors().add(
            TableDescriptorBuilder.newBuilder(htd)
            .addColumnFamily(cfDescriptor).build());
{code}

Is this sane?

> shell 'alter' command no longer distinguishes column add/modify/delete
> ----------------------------------------------------------------------
>
>                 Key: HBASE-18893
>                 URL: https://issues.apache.org/jira/browse/HBASE-18893
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Mike Drob
>
> After HBASE-15641 all 'alter' commands go through a single modifyTable call 
> at the end, so we no longer can easily distinguish add, modify, and delete 
> column events. This potentially affects coprocessors that needed the update 
> notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before 
> without undoing the batching that seems pretty useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to