[
https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reassigned HBASE-18893:
---------------------------------
Assignee: Mike Drob
Summary: Remove Add/Modify/DeleteColumnFamilyProcedure in favor of
using ModifyTableProcedure (was: shell 'alter' command no longer distinguishes
column add/modify/delete)
Fix Version/s: 2.0.0-alpha-4
Description:
The shell changed from using separate add/modify/delete column calls to
funneling everything through modify table for performance reasons. We know that
using modify table works for everything. Let's drop the old code for
Add/Modify/Delete Column so that we have a lower maintenance burden and fewer
code paths to reason about.
-------- Was: shell 'alter' command no longer distinguishes column
add/modify/delete
After HBASE-15641 all 'alter' commands go through a single modifyTable call at
the end, so we no longer can easily distinguish add, modify, and delete column
events. This potentially affects coprocessors that needed the update
notifications for new or removed columns.
Let's let the shell still make separate behaviour calls like it did before
without undoing the batching that seems pretty useful.
was:
After HBASE-15641 all 'alter' commands go through a single modifyTable call at
the end, so we no longer can easily distinguish add, modify, and delete column
events. This potentially affects coprocessors that needed the update
notifications for new or removed columns.
Let's let the shell still make separate behaviour calls like it did before
without undoing the batching that seems pretty useful.
Component/s: (was: shell)
master
Coprocessors
Targeting for a4 and updating title since this impacts CPs.
bq. You'd remove AddCFP and DCFP in favor of what? A modifytable procedure?
Yep.
> Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using
> ModifyTableProcedure
> ------------------------------------------------------------------------------------
>
> Key: HBASE-18893
> URL: https://issues.apache.org/jira/browse/HBASE-18893
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, master
> Reporter: Mike Drob
> Assignee: Mike Drob
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18893.patch
>
>
> The shell changed from using separate add/modify/delete column calls to
> funneling everything through modify table for performance reasons. We know
> that using modify table works for everything. Let's drop the old code for
> Add/Modify/Delete Column so that we have a lower maintenance burden and fewer
> code paths to reason about.
> -------- Was: shell 'alter' command no longer distinguishes column
> add/modify/delete
> After HBASE-15641 all 'alter' commands go through a single modifyTable call
> at the end, so we no longer can easily distinguish add, modify, and delete
> column events. This potentially affects coprocessors that needed the update
> notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before
> without undoing the batching that seems pretty useful.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
