[
https://issues.apache.org/jira/browse/HBASE-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209555#comment-16209555
]
Josh Elser commented on HBASE-14077:
------------------------------------
[~eclark], I'm worried that this is breaking compatibility with older 1.x
clients.
After including this change in a local build, I'm seeing some failures around a
client executing a CoprocessorService (specifically the AccessControlService)
The client submits a CP service name of {{AccessControlService}} but the
RegionServer has registered {{hbase.pb.AccessControlService}} instead. While
there is no outward change in the Java-generated code from the namespace
change, there is an implicit one, specifically around
{{ServiceDescriptor.getFullName()}}.
FYI [~enis]
> Add package to hbase-protocol protobuf files.
> ---------------------------------------------
>
> Key: HBASE-14077
> URL: https://issues.apache.org/jira/browse/HBASE-14077
> Project: HBase
> Issue Type: Bug
> Components: Protobufs
> Affects Versions: 2.0.0, 1.2.0, 1.3.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14077.patch
>
>
> c++ generated code is currently in the default namespace. That's bad
> practice; so lets fix it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
