[
https://issues.apache.org/jira/browse/HBASE-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211299#comment-16211299
]
Mike Drob commented on HBASE-19051:
-----------------------------------
{code}
+ assertArrayEquals(twoRegionsSplits[0], "50000000".getBytes());
+ assertArrayEquals(splits[0], "10000000".getBytes());
+ assertArrayEquals(splits[1], "20000000".getBytes());
+ assertArrayEquals(splits[1], "10000000".getBytes());
{code}
nit: swap argument order
Can you add a test for when a value doesn't divide exactly evenly?
Otherwise, patch looks good and makes sense. Thanks for the contribution, [~Yun
Zhao]
> Add new split algorithm for num string
> --------------------------------------
>
> Key: HBASE-19051
> URL: https://issues.apache.org/jira/browse/HBASE-19051
> Project: HBase
> Issue Type: Improvement
> Reporter: Yun Zhao
> Assignee: Yun Zhao
> Priority: Minor
> Attachments: HBASE-19051.master.001.patch
>
>
> We will use the reversed sequential number or phone number as the first part
> of rowkey, there is no split algorithm to create a pre-split table, only by
> specify the split points.
> {code}
> create 't1','f', SPLITS => ['1','2','3','4','5','6','7','8','9']
> {code}
> Add new split algorithm DecStringSplit.
> {code}
> create 't2','f', { NUMREGIONS => 10 , SPLITALGO => 'DecStringSplit' }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
