[
https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188868#comment-13188868
]
Phabricator commented on HBASE-5199:
------------------------------------
Liyin has commented on the revision "[jira][HBASE-5199] Delete out of TTL store
files before compaction selection ".
@khemani: I see your point, which inspire me to a new idea: When holding a
read lock for selection compaction candidates, it should also select the
expired deletion store file candidates. After when processing
completeCompaction logic within the write lock, it will delete the expired
store files.
So this approach should NOT introduce any potential dead lock risk since
there is no read or write lock introduced by this feature at all.
@tedyu: Thanks for pointing it out. And no additional
notifyChangedReadersObservers() is needed if implementing in this way.
REVISION DETAIL
https://reviews.facebook.net/D1311
> Delete out of TTL store files before compaction selection
> ---------------------------------------------------------
>
> Key: HBASE-5199
> URL: https://issues.apache.org/jira/browse/HBASE-5199
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D1311.1.patch, D1311.2.patch, D1311.3.patch
>
>
> Currently, HBase deletes the out of TTL store files after compaction. We can
> change the sequence to delete the out of TTL store files before selecting
> store files for compactions.
> In this way, HBase can keep deleting the old invalid store files without
> compaction, and also prevent from unnecessary compactions since the out of
> TTL store files will be deleted before the compaction selection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
