[ 
https://issues.apache.org/jira/browse/HBASE-19046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213852#comment-16213852
 ] 

Chia-Ping Tsai commented on HBASE-19046:
----------------------------------------

bq. compaction.getRequest().getFiles() returns Collection<? extends StoreFile> 
not List. So we can not directly use the above. Or else we have to pass 
Collection<StoreFile> to CP hook not List.. That is why did not change here. 
What do u say?
Got it. +1

> RegionObserver#postCompactSelection  Passing an ImmutableList param of PB type
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-19046
>                 URL: https://issues.apache.org/jira/browse/HBASE-19046
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19046.patch
>
>
> Dont think there is any specific need for passing this PB type.  We can just 
> pass an unmodifiableList list object. Javadoc can say this is an 
> unmodifiableList .  Thats it . No need  that the type itself to be 
> Immutable...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to