[ 
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214990#comment-16214990
 ] 

Anoop Sam John commented on HBASE-19057:
----------------------------------------

As discussed above, better we keep the original way of filterRowKey() for the 
AND filter also.. We were not having the short circuit return even there.  So 
OR case, we follow same even now.  For AND also better we dont do short 
circuit.  Pls add fat comments in both these places abt why we dont do short 
circuit returns.   Else patch LGTM

> Fix other code review comments about FilterList Improvement
> -----------------------------------------------------------
>
>                 Key: HBASE-19057
>                 URL: https://issues.apache.org/jira/browse/HBASE-19057
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filters
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19057-HBASE-18410.v1.patch, 
> HBASE-19057-HBASE-18410.v2.patch
>
>
> Open this issue to  fix conflict , run HadoopQA  and gather other feedback. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to