[ 
https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216672#comment-16216672
 ] 

Hudson commented on HBASE-18893:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3940 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3940/])
HBASE-18893 remove add/delete/modify column (mdrob: rev 
a1bc20ab5886acd65cc2b693eccf8e736d373b6b)
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AddColumnFamilyProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyColumnFamilyProcedure.java
* (delete) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestDeleteColumnFamilyProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestWithDisabledAuthorization.java
* (edit) hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* (delete) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyColumnFamilyProcedure.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
* (delete) 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestAddColumnFamilyProcedure.java
* (delete) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteColumnFamilyProcedure.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java


> Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using 
> ModifyTableProcedure
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-18893
>                 URL: https://issues.apache.org/jira/browse/HBASE-18893
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, master
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>             Fix For: 3.0.0, 2.0.0-alpha-4
>
>         Attachments: HBASE-18893.patch, HBASE-18893.v2.patch, 
> HBASE-18893.v3.patch, HBASE-18893.v4.patch
>
>
> The shell changed from using separate add/modify/delete column calls to 
> funneling everything through modify table for performance reasons. We know 
> that using modify table works for everything. Let's drop the old code for 
> Add/Modify/Delete Column so that we have a lower maintenance burden and fewer 
> code paths to reason about.
> -------- Was: shell 'alter' command no longer distinguishes column 
> add/modify/delete
> After HBASE-15641 all 'alter' commands go through a single modifyTable call 
> at the end, so we no longer can easily distinguish add, modify, and delete 
> column events. This potentially affects coprocessors that needed the update 
> notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before 
> without undoing the batching that seems pretty useful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to