[ 
https://issues.apache.org/jira/browse/HBASE-19018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217302#comment-16217302
 ] 

Sean Busbey commented on HBASE-19018:
-------------------------------------

{quote}
-1      test4tests      0m 0s   The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch.
{quote}

no specific tests, since this is fixing a missing dependency. existing test 
failure covers it.

> Use of hadoop internals that require bouncycastle should declare bouncycastle 
> dependency
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-19018
>                 URL: https://issues.apache.org/jira/browse/HBASE-19018
>             Project: HBase
>          Issue Type: Bug
>          Components: dependencies, test
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19018.0.patch, HBASE-19018.1.patch
>
>
> The tests for HBASE-15806 rely on a Hadoop internal class, 
> {{KeyStoreTestUtil}}, which in turn relies on the Bouncycastle library for 
> certificate generation.
> when building / running with Hadoop 2.7.1, we accidentally get a bouncycastle 
> implementation via a transitive dependency of {{hadoop-minikdc}}. When 
> attempting to run against Hadoop 3.0.0-alpha4 and 3.0.0-beta1 (and presumably 
> future Hadoop 3.y releases), this bouncycastle jar is no longer pulled in and 
> we fail with a CNFE.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to