[ 
https://issues.apache.org/jira/browse/HBASE-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217568#comment-16217568
 ] 

stack commented on HBASE-19048:
-------------------------------

.003 Redoes the patch removing IA.Private params rather than remove the 
pre/post. I left in place the RSGroups hooks. Its odd that RSGroup has hooks in 
core MasterObserver, that RSGroup has AccessController run checks for perms.  I 
was thinking of purging the RSGroup hooks from MasterObserver but its denoted a 
@CoreCoprocessor as it is.... And you probably should have perms before you are 
allowed mess with RSGroups.... Ugh.

One weird thing is necessity of a 1 second pause granting a permission in test. 
Cannot figure why needed here and no where else.

> Cleanup MasterObserver hooks which takes IA private params
> ----------------------------------------------------------
>
>                 Key: HBASE-19048
>                 URL: https://issues.apache.org/jira/browse/HBASE-19048
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Anoop Sam John
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19048.master.001.patch, 
> HBASE-19048.master.002.patch, HBASE-19048.master.003.patch
>
>
> These are the ones in MasterObserver
> {code}
>               preAbortProcedure        -  ProcedureExecutor
>               postGetProcedures        - Procedure
>               postGetLocks             - LockedResource
>               preRequestLock   - LockType
>               postRequestLock  - LockType
>               preLockHeartbeat         - LockProcedure
>               postLockHeartbeat        - LockProcedure
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to