[
https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220710#comment-16220710
]
Josh Elser commented on HBASE-18906:
------------------------------------
{noformat}
- /** Wait for all current flushes of the region to complete
- */
- // TODO HBASE-18906. Check the usage (if any) in Phoenix and expose this or
give alternate way for
- // Phoenix needs.
public void waitForFlushes() {
+ waitForFlushes(0);// Unbound wait
+ }
{noformat}
Maybe you accidentally dropped the javadoc comment on {{waitForFlushes()}}?
Would be nice to restore that -- I can do that on commit after QA completes if
people are OK with that.
+1 otherwise. Thanks for Mike's suggestion yesterday and Anoop for fixing it
quickly :)
> Provide Region#waitForFlushes API
> ---------------------------------
>
> Key: HBASE-18906
> URL: https://issues.apache.org/jira/browse/HBASE-18906
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18906.patch, HBASE-18906_V2.patch
>
>
> Expose an API for the CPs to wait for all on going flushes in a Region. The
> API should support taking a time out.
> Background
> While reviewing HBASE-18183, Andy pointed out that Phoenix uses
> waitForFlushesAndCompactions and/or waitForFlushes for diff reasons. This
> issue is to see why they need them and whether alternate ways are possible.
> This seems to be too much internal stuff and a normal CP hook calling these
> would be dangerous.
> If there are alternate ways for Phoenix not to use this and not landing in
> issues (As said by Andy) we should suggest/fix for them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
