[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222232#comment-16222232
]
Hudson commented on HBASE-13346:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3954 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3954/])
HBASE-13346: Clean up Filter package for post 1.0 s/KeyValue/Cell/g
(anoopsamjohn: rev 82b1c320f072a8032c9727a93ae106b5fcdc8108)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RandomRowFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithAND.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterFromRegionSide.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PageFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MobReferenceOnlyFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/QualifierFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/RowFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/KeyOnlyFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnCountGetFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestInvocationRecordFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ValueFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ColumnTracker.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/DeleteTracker.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestMultiRowRangeFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SkipFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterAllFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/PrefixFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueExcludeFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
* (edit)
hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/AbstractTestScanCursor.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/Filter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPaginationFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyOnlyFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
* (delete)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterWrapper.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/ColumnCountOnRowFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FamilyFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
* (add)
hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FilterWrapper.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFirstKeyValueMatchingQualifiersFilter.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanDeleteTracker.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestSingleColumnValueFilter.java
> Clean up Filter package for post 1.0 s/KeyValue/Cell/g
> ------------------------------------------------------
>
> Key: HBASE-13346
> URL: https://issues.apache.org/jira/browse/HBASE-13346
> Project: HBase
> Issue Type: Bug
> Components: API, Filters
> Affects Versions: 2.0.0
> Reporter: Lars George
> Assignee: Tamas Penzes
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-13346.master.001.patch,
> HBASE-13346.master.002.patch, HBASE-13346.master.003.patch,
> HBASE-13346.master.003.patch, HBASE-13346.master.004.patch,
> HBASE-13346.master.005.patch, HBASE-13346.master.006.patch,
> HBASE-13346.master.007.patch, HBASE-13346.master.008.patch,
> HBASE-13346.master.009.patch, HBASE-13346.master.010.patch,
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch,
> HBASE-13346.master.011.patch, HBASE-13346.master.011.patch
>
>
> Since we have a bit of a messy Filter API with KeyValue vs Cell reference
> mixed up all over the place, I recommend cleaning this up once and for all.
> There should be no {{KeyValue}} (or {{kv}}, {{kvs}} etc.) in any method or
> parameter name.
> This includes deprecating and renaming filters too, for example
> {{FirstKeyOnlyFilter}}, which really should be named {{FirstKeyValueFilter}}
> as it does _not_ just return the key, but the entire cell. It should be
> deprecated and renamed to {{FirstCellFilter}} (or {{FirstColumnFilter}} if
> you prefer).
> In general we should clarify and settle on {{KeyValue}} vs {{Cell}} vs
> {{Column}} in our naming. The latter two are the only ones going forward with
> the public API, and are used synonymous. We should carefully check which is
> better suited (is it really a specific cell, or the newest cell, aka the
> newest column value) and settle on a naming schema.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
