[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222646#comment-16222646
]
stack commented on HBASE-18945:
-------------------------------
As said over on HBASE-19052, that 'approach' is brittle.
Wouldn't changing the trailer require a change in file version? Can hbase2 not
write old style until cluster is all up on hbase2? hbase2 could write old style
but when it read in the Interface, it could substitute the Impl? Better do this
than require poor old user upgrade whole cluster first to latest branch-1 (we
may have to do this for rolling upgrade but perhaps we can avoid it... that'd
be great).
> Make a IA.LimitedPrivate interface for CellComparator
> -----------------------------------------------------
>
> Key: HBASE-18945
> URL: https://issues.apache.org/jira/browse/HBASE-18945
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0-alpha-4
>
> Attachments: 18945-addendum-branch-2.txt, HBASE-18495.patch,
> HBASE-18945_2.patch, HBASE-18945_3.patch, HBASE-18945_4.patch,
> HBASE-18945_5.patch, HBASE-18945_6.patch, HBASE-18945_6.patch,
> HBASE-18945_7.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we
> expose CellComparator as a public interface so that it could be used in
> Region/Store interfaces to be exposed to CPs.
> Currently the Comparator is exposed in Region, STore and StoreFile. There is
> another discussion whether to expose it at all layers or only at Region.
> However since we are exposing this to CPs CellComparator being @Private is
> not the ideal way to do it. We have to change it to LimitedPrivate. But
> CellComparator has lot of additional methods which are internal (like where a
> Cell is compared with an incoming byte[] used in index comparsions etc).
> One way to expose is that as being done now in HBASE-18826 - by exposing the
> return type as Comparator<Cell>. But this is not powerful. It only allows to
> compare cells. So we try to expose an IA.LimitedPrivate interface that is
> more powerful and allows comparing individual cell components also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
