[ 
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223034#comment-16223034
 ] 

Andrew Purtell commented on HBASE-19024:
----------------------------------------

The reported unit test failures are legit and need to be fixed.

I see this FWIW, with the patch applied. Passes at current HEAD of master. 

{noformat}
[ERROR] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
58.959 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestHRegion
[ERROR] 
testMemstoreSnapshotSize(org.apache.hadoop.hbase.regionserver.TestHRegion)  
Time elapsed: 0.035 s  <<< FAILURE!
java.lang.AssertionError: The regionserver should have thrown an exception
        at 
org.apache.hadoop.hbase.regionserver.TestHRegion.testMemstoreSnapshotSize(TestHRegion.java:352)
{noformat}



> provide a configurable option to hsync WAL edits to the disk for better 
> durability
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-19024
>                 URL: https://issues.apache.org/jira/browse/HBASE-19024
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>         Environment: 
>            Reporter: Vikas Vishwakarma
>            Assignee: Harshal Jain
>         Attachments: master.patch, master.v2.patch
>
>
> At present we do not have an option to hsync WAL edits to the disk for better 
> durability. In our local tests we see 10-15% latency impact of using hsync 
> instead of hflush which is not very high.  
> We should have a configurable option to hysnc WAL edits instead of just 
> sync/hflush which will call the corresponding API on the hadoop side. 
> Currently HBase handles both SYNC_WAL and FSYNC_WAL as the same calling 
> FSDataOutputStream sync/hflush on the hadoop side. This can be modified to 
> let FSYNC_WAL call hsync on the hadoop side instead of sync/hflush. We can 
> keep the default value to sync as the current behavior and hsync can be 
> enabled based on explicit configuration.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to