[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-19114:
-------------------------
Description:
Changes so far:
- Moved DrainingServerTracker and RegionServerTracker to
hbase-server:o.a.h.h.master.
- Move Abortable to hbase-common. Since it's IA.Private and independent of
anything, moving it to hbase-common which is at bottom of the dependency tree
is better.
- Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver
- Moved SplitOrMergeTracker to oahh.master (because it depends on a PB)
- Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to
keep hbase-zookeeper very independent and hence at lowest levels in our
dependency tree.
- ZKUtil is a huge tangle since it's linked to almost everything in
[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto
functions (mergeFrom, PBmagic, etc). So what i did was:
**Pulled down common and basic protobuf functions (which only depend on
com.google.protobuf.\*) to hbase-common so other code depending on them can be
pulled down if possible/wanted in future. This will help future dependency
untangling too. These are ProtobufMagic and ProtobufHelpers.
**Didn't move any hbase-specific PB stuff to hbase-common. We can't pull
things into hbase-common which add dependency between it and
hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them.
- DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in
HConstants (since it's in hbase-common) and using it in hbase-zookeeper.
RegionInfo.DEFAULT_REPLICA_ID too takes its value from it.
was:
Changes so far:
- Moved DrainingServerTracker and RegionServerTracker to
hbase-server:o.a.h.h.master.
- Move Abortable to hbase-common. Since it's IA.Private and independent of
anything, moving it to hbase-common which is at bottom of the dependency tree
is better.
- Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver
- Moved SplitOrMergeTracker to oahh.master (because it depends on a PB)
- Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to
keep hbase-zookeeper very independent and hence at lowest levels in our
dependency tree.
- ZKUtil is a huge tangle since it's linked to almost everything in
[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto
functions (mergeFrom, PBmagic, etc). So what i did was:
**Pulled down common and basic protobuf functions (which only depend on
com.google.protobuf.*) to hbase-common so other code depending on them can be
pulled down if possible/wanted in future. This will help future dependency
untangling too. These are ProtobufMagic and ProtobufHelpers.
**Didn't move any hbase-specific PB stuff to hbase-common. We can't pull
things into hbase-common which add dependency between it and
hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them.
- DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in
HConstants (since it's in hbase-common) and using it in hbase-zookeeper.
RegionInfo.DEFAULT_REPLICA_ID too takes its value from it.
> Split out o.a.h.h.zookeeper from hbase-server and hbase-client
> --------------------------------------------------------------
>
> Key: HBASE-19114
> URL: https://issues.apache.org/jira/browse/HBASE-19114
> Project: HBase
> Issue Type: Sub-task
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-19114.master.001.patch
>
>
> Changes so far:
> - Moved DrainingServerTracker and RegionServerTracker to
> hbase-server:o.a.h.h.master.
> - Move Abortable to hbase-common. Since it's IA.Private and independent of
> anything, moving it to hbase-common which is at bottom of the dependency tree
> is better.
> - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver
> - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB)
> - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to
> keep hbase-zookeeper very independent and hence at lowest levels in our
> dependency tree.
> - ZKUtil is a huge tangle since it's linked to almost everything in
> [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto
> functions (mergeFrom, PBmagic, etc). So what i did was:
> **Pulled down common and basic protobuf functions (which only depend on
> com.google.protobuf.\*) to hbase-common so other code depending on them can
> be pulled down if possible/wanted in future. This will help future dependency
> untangling too. These are ProtobufMagic and ProtobufHelpers.
> **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull
> things into hbase-common which add dependency between it and
> hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them.
> - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in
> HConstants (since it's in hbase-common) and using it in hbase-zookeeper.
> RegionInfo.DEFAULT_REPLICA_ID too takes its value from it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
