[
https://issues.apache.org/jira/browse/HBASE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5230:
-------------------------------
Attachment: D1353.1.patch
mbautin requested code review of "[jira] [HBASE-5230] Extend TestCacheOnWrite
to ensure we don't cache data blocks on compaction".
Reviewers: nspiegelberg, tedyu, Liyin, stack, JIRA
Adding another test method to TestCacheOnWrite that generates some data,
clears the cache, does a compaction through HRegion API, and verifies that no
data blocks have been cached. When I wrote the unit test, it failed, so I
modified compaction code to use an alternative CacheConfig instance with
cache-on-write turned off for data blocks. This fixed the unit test. We should
also be able to resolve HBASE-3976 when this goes in.
TEST PLAN
Run all unit tests
REVISION DETAIL
https://reviews.facebook.net/D1353
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2817/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Unit test to ensure compactions don't cache data on write
> ---------------------------------------------------------
>
> Key: HBASE-5230
> URL: https://issues.apache.org/jira/browse/HBASE-5230
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Minor
> Attachments: D1353.1.patch
>
>
> Create a unit test for HBASE-3976 (making sure we don't cache data blocks on
> write during compactions even if cache-on-write is enabled generally
> enabled). This is because we have very different implementations of
> HBASE-3976 without HBASE-4422 CacheConfig (on top of 89-fb, created by Liyin)
> and with CacheConfig (presumably it's there but not sure if it even works,
> since the patch in HBASE-3976 may not have been committed). We need to create
> a unit test to verify that we don't cache data blocks on write during
> compactions, and resolve HBASE-3976 so that this new unit test does not fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
