[ 
https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223204#comment-16223204
 ] 

Sean Busbey commented on HBASE-19110:
-------------------------------------

{code}
 fs = c == null? null: FileSystem.get(c);
{code}

nit: an if block will be clearer (esp given the spacing)

+1 on v2 as is or  with the nit addressed

> Add default for Server#isStopping
> ---------------------------------
>
>                 Key: HBASE-19110
>                 URL: https://issues.apache.org/jira/browse/HBASE-19110
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>            Priority: Minor
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19110.master.001.patch, 
> HBASE-19110.master.002.patch
>
>
> Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", 
> we moved the isStopping method back into Server. In a late review, [~appy] 
> suggested that I should have had the Interface provide a default. This issue 
> is about doing as [~appy] suggested.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to