[
https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223352#comment-16223352
]
Chia-Ping Tsai commented on HBASE-18438:
----------------------------------------
bq. That should have failed, right?
Yep, it should fail.
I'm investigating how an error like this could have occurred. A possible reason
is our hbase folder is located at {{/hbase}} (see YETUS-571), but it seems we
put hbase in {{/testptch}} (BTW, is it typo?). [~busbey] Can we hack the Yetus
used in our QA? The temporary checkstyle report which is revised by Yetus can
give us handy hint.
{code:title=checkstyle.sh}
// DON'T remove them
rm "${tmp}" "${tmp}.1" 2>/dev/null
{code}
> Precommit doesn't warn about unused imports
> -------------------------------------------
>
> Key: HBASE-18438
> URL: https://issues.apache.org/jira/browse/HBASE-18438
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Mike Drob
> Assignee: Chia-Ping Tsai
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-18438.patch, HBASE-18438.v2.patch,
> HBASE-18438.v2.patch
>
>
> On HBASE-18419 I accidentally included an unused import in my patch, but
> precommit didn't flag it. Use this issue to diagnose and fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
