[
https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223973#comment-16223973
]
Chia-Ping Tsai edited comment on HBASE-18438 at 10/29/17 2:16 PM:
------------------------------------------------------------------
Ya, the checkstyle report is back. :)
We already have the rule of import order in checkstyle.xml, and it looks like
the [google style|https://google.github.io/styleguide/javaguide.html]. I feel
the current rule is good enough, so I will commit the patch from [~mdrob] and
close this issue.
was (Author: chia7712):
Ya, the checkstyle report is back. :)
We already have the rule of import order in checkstyle.xml, and it looks like
the [good style|https://google.github.io/styleguide/javaguide.html]. I feel the
current rule is good enough, so I will commit the patch from [~mdrob] and close
this issue.
> Precommit doesn't warn about unused imports
> -------------------------------------------
>
> Key: HBASE-18438
> URL: https://issues.apache.org/jira/browse/HBASE-18438
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Mike Drob
> Assignee: Chia-Ping Tsai
> Priority: Critical
> Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
> Attachments: HBASE-18438.patch, HBASE-18438.v2.patch,
> HBASE-18438.v2.patch
>
>
> On HBASE-18419 I accidentally included an unused import in my patch, but
> precommit didn't flag it. Use this issue to diagnose and fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
