[ 
https://issues.apache.org/jira/browse/HBASE-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225720#comment-16225720
 ] 

Andrew Purtell commented on HBASE-19122:
----------------------------------------

bq. preCompact and preFlush can bypass by returning null scanner; shut it down

+1, we shouldn't allow bypass of compact or flush activity. 

After making that change returning a null scanner becomes an implementation 
error. One option is to throw a NPE and ensure it aborts the server, since it 
is a coprocessor implementation bug. We could also log at ERROR level and 
continue, but something has already gone very wrong.

> preCompact and preFlush can bypass by returning null scanner; shut it down
> --------------------------------------------------------------------------
>
>                 Key: HBASE-19122
>                 URL: https://issues.apache.org/jira/browse/HBASE-19122
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, Scanners
>            Reporter: stack
>             Fix For: 2.0.0-beta-1
>
>
> Noticed by [~anoop.hbase] during review of HBASE-18770, preCompact and 
> preFlush can bypass normal processing by returning null. They are not 
> bypasable by ordained route. We should shut down this avenue.
> The preCompact at least may be new coming in with:
> {code}
> tree dbf13093842f85a713f023d7219caccf8f4eb05f
> parent a4dcf51415616772e462091ce93622f070ea8810
> author zhangduo <[email protected]> Sat Apr 9 16:18:08 2016 +0800
> committer zhangduo <[email protected]> Sun Apr 10 09:26:28 2016 +0800
> HBASE-15527 Refactor Compactor related classes
> {code}
> Would have to dig in more to figure for sure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to