[
https://issues.apache.org/jira/browse/HBASE-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227749#comment-16227749
]
Umesh Agashe commented on HBASE-18961:
--------------------------------------
Feedback from review session with [~stack]:
# # Comment that batchMutate() and batchReplay() share most of the code and are
related. Same for classes ReplayBatchOperation and MutationBatchOperation
# Release note the intent: Trying to unify batchMutate() and mutateRows() calls
(2 write paths)
# Existing bug: add TODO for Validation with timestamp before locking and
update with new timestamp after lock inconsistency
# Add a comment that once row is locked op is considered as In-progress for
method lockRowsAndBuildMiniBatch()
# Add Javadoc with: Mini-batch is window over batch and its sequential
# change updateMiniBatchOperations to prepareMiniBatchOperations()
# Comment on buildWALEdit() in super class has replay in it which has separate
subclass, move it and add more comments
# Move all replay/ not replay checks out of doMiniBatchMutate()
# [~stack] asked about adding more unit tests but can be done in HBASE-18962 as
it will have new functionality.
> doMiniBatchMutate() is big, split it into smaller methods
> ---------------------------------------------------------
>
> Key: HBASE-18961
> URL: https://issues.apache.org/jira/browse/HBASE-18961
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Affects Versions: 2.0.0-alpha-3
> Reporter: Umesh Agashe
> Assignee: Umesh Agashe
> Fix For: 2.0.0-beta-1
>
> Attachments: hbase-18961.master.001.patch,
> hbase-18961.master.002.patch
>
>
> Split doMiniBatchMutate() and improve readability.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
