[
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234771#comment-16234771
]
Appy commented on HBASE-18925:
------------------------------
Fixed the 3 checkstyle errors. (This patch is anyways fixing a lot of them, net
-53 errors)
Last precommit was +1 on tests, so i suspected this was just flakyness.
Ran findHangingTests.py script on
[patch-unit-root.txt|https://builds.apache.org/job/PreCommit-HBASE-Build/9547/artifact/patchprocess/patch-unit-root.txt]
and found the culprit tests.
{noformat}
Found 2 failed tests of which 0 timed out:
master.TestRollingRestart
client.TestAdmin2
{noformat}
Unlike previous cases when the tests reported by the script were failing
locally and consistently (and the train of patches was to fix them), these two
passed locally 3 times in row.
Committing to master and branch-2
Thanks again for the review [~stack].
> Need updated mockito for using java optional
> --------------------------------------------
>
> Key: HBASE-18925
> URL: https://issues.apache.org/jira/browse/HBASE-18925
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Priority: Major
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18925.master.001.patch,
> HBASE-18925.master.002.patch, HBASE-18925.master.002.patch,
> HBASE-18925.master.003.patch, HBASE-18925.master.004.patch,
> HBASE-18925.master.005.patch, HBASE-18925.master.006.patch,
> HBASE-18925.master.007.patch, HBASE-18925.master.008.patch,
> HBASE-18925.master.009.patch
>
>
> Came up when i was trying to test HBASE-18878.
> It kept failing because mock of RpcCall returned null where return type was
> Optional<User>.
> Instead, we want it to return Optional.empty().
> New mockito versions support this (and other java8 things) -
> https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2
> We use mockito-all which was last released in Dec2014. However, mockito-core
> has had more than 50 releases after that
> (https://mvnrepository.com/artifact/org.mockito/mockito-core).
> We need to change our deps from mockito-all to mockito-core.
> However that comes with fair breakages, so this is not a simple task of
> changing pom files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
