[ 
https://issues.apache.org/jira/browse/HBASE-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238788#comment-16238788
 ] 

Sean Busbey commented on HBASE-19152:
-------------------------------------

okay failures:

{code}
Checking against things we don't expect to include in the source tarball (git 
related, hbase-native-client, etc.)
Any output here are unexpected differences between the source artifact we'd 
make for an RC and the current branch.
The expected differences are on the < side and the current differences are on 
the > side.
In a given set of differences, '.' refers to the branch in the repo and 
'unpacked_src_tarball' refers to what we pulled out of the tarball.
0a1
> Only in /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball: 
> ${project.basedir}
2,4c3,21
< Only in .: .gitattributes
< Only in .: .gitignore
{code}

the git related files are present in the source tarball now, so those two 
expected gaps can be removed.

{code}
< Only in .: hbase-native-client
---
{code}

the hbase-native-client is also now in the source tarball so this line should 
be removed. HBASE-19176 would fix this in branch-2, but won't help master or 
other branches.

{code}
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-build-configuration:
>  src
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-build-support/hbase-error-prone/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-client/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-common/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-external-blockcache/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-hadoop2-compat/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-http/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-metrics/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-protocol/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-protocol-shaded/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-rest/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-server/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-shaded/hbase-shaded-client:
>  dependency-reduced-pom.xml
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-shaded/hbase-shaded-mapreduce:
>  dependency-reduced-pom.xml
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-shell/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-spark/src: 
> site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-spark-it/src:
>  site
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-testing-util:
>  src
> Only in 
> /tmp/hbase-srctarball-test-27514.13333/unpacked_src_tarball/hbase-thrift/src: 
> site
{code}

these are made by the build process. They show up now because {{mvn clean}} 
doesn't impact non-target directories and we're no longer doing a build in the 
component directory.

probably best to generate the diff prior to doing the build in the unpacked 
source tarball. we can't do a git clean since it's not a repo and doing a build 
in the component directory will add time unnecessarily.

> Update refguide 'how to build an RC' and the make_rc.sh script
> --------------------------------------------------------------
>
>                 Key: HBASE-19152
>                 URL: https://issues.apache.org/jira/browse/HBASE-19152
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-beta-1
>
>         Attachments: 
> 0001-HBASE-19152-Update-refguide-how-to-build-an-RC-and-t.patch, 
> 0001-HBASE-19152-Update-refguide-how-to-build-an-RC-and-t.patch, 
> HBASE-19152.master.001.patch, HBASE-19152.master.002.patch, 
> HBASE-19152.master.003.patch, HBASE-19152.master.004.patch, 
> HBASE-19152.master.005.patch, HBASE-19152.master.006.patch, 
> HBASE-19152.master.007.patch, HBASE-19152.master.008.patch
>
>
> Update the section on how to build an RC. In particular, note that tags 
> should be signed and talk up the new way of building the src tgz (after a 
> Sean suggestion) including removal of old means src.xml from hbase-assembly. 
> Update the make_rc.sh script so it works for branch-2 builds.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to