[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190873#comment-13190873
]
stack commented on HBASE-5237:
------------------------------
Thanks for explanation Ram. This code is hard to follow. That a call to
getRegionPlan returning null means "...there are no regionservers on line" and
then setting a flag on the timeout monitor to indicate that seems like extreme
indirection. We can fix that in another issue. Please commit this patch to
0.92.
> Addendum for HBASE-5160 and HBASE-4397
> --------------------------------------
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.5
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
