[
https://issues.apache.org/jira/browse/HBASE-19160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240837#comment-16240837
]
Hudson commented on HBASE-19160:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4008 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4008/])
HBASE-19160 expose CellComparator as IA.Public (mdrob: rev
9ee8e2714df54345743ddf18bf23899872930b2c)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSortReducer.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCellFlatSet.java
* (edit)
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileReader.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/AbstractTestScanQueryMatcher.java
* (edit)
hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/InclusiveStopFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/util/CollectionBackedScanner.java
* (edit)
hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestImportTsv.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TextSortReducer.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListBase.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/PutSortReducer.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/KeyValueScanFixture.java
* (edit)
hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/HBaseContext.scala
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultMemStore.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueScanFixture.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
* (edit)
hbase-common/src/test/java/org/apache/hadoop/hbase/util/RedundantKVGenerator.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/SyncTable.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
> Re-expose CellComparator
> ------------------------
>
> Key: HBASE-19160
> URL: https://issues.apache.org/jira/browse/HBASE-19160
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha-4
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Critical
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: 19160.addendum, HBASE-19160.patch, HBASE-19160.v2.patch,
> HBASE-19160.v3.patch, HBASE-19160.v4.patch
>
>
> On HBASE-18995 we moved a bunch of public methods to Private places. This
> inadvertently breaks donwstream consumers. Let's see if we can ease up on
> some of the lockdown and make life easier for them.
> Copying [~ram_krish]'s previous analysis:
> {quote}
> I read the Crunch projec't hbase-support related code.
> -> It uses both CellUtil (Public exposed) and KeyValueUtil (@Private) classes
> for helper methods.
> -> All methods in CellUtil that are getting used are even now exposed in
> branch-2's CellUtil and they are very common helper methods. So we are safe
> here.
> -> Wrt KeyValueUtil the API is createFirstOnRow(). It is used in test cases
> and in some core code. In most of the places they are trying to create the
> splitKeys from the region's start keys and that is also getting persisted. I
> think here they can safely create a cell out of the given byte[] of the row.
> But there is one place where they are trying to do some scanning on a
> HFileScanner directly (@Private) scanner. So this should be changed because
> it is an internal interface for us. And on this scanner they have copied our
> seekTo() code into their source files for some scanning purpose. In this code
> they are actually using the KvUtil.createFirstOnRow() to seek to that first
> cell of that row.
> More over I think in branch-2 we are restricting even CPs from accessing some
> of our internal scanners and they can only use InternalScanner interface. So
> this code in crunch needs heavy refactoring to work with branch-2 in case
> they want to fit into the Public/Private exposed semantics that HBase
> presents to the downstreamers.
> -> If still they want some APIs like this we can expose
> CellUtil#createFirstOnRow, createLastOnRow, createFirstOnCol and
> createLastOnCol at the maximum. I think others are not useful and are more
> internal stuffs.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
