[
https://issues.apache.org/jira/browse/HBASE-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191307#comment-13191307
]
Hadoop QA commented on HBASE-5255:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511518/5255-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -145 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 84 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/837//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/837//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/837//console
This message is automatically generated.
> Use singletons for OperationStatus to save memory
> -------------------------------------------------
>
> Key: HBASE-5255
> URL: https://issues.apache.org/jira/browse/HBASE-5255
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 0.92.0, 0.90.5
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
> Labels: performance
> Fix For: 0.94.0, 0.92.1
>
> Attachments: 5255-v2.txt,
> HBASE-5255-0.92-Use-singletons-to-remove-unnecessary-memory-allocati.patch,
> HBASE-5255-trunk-Use-singletons-to-remove-unnecessary-memory-allocati.patch
>
>
> Every single {{Put}} causes the allocation of at least one
> {{OperationStatus}}, yet {{OperationStatus}} is almost always stateless, so
> these allocations are unnecessary and could be avoided. Attached patch adds
> a few singletons and uses them, with no public API change. I didn't test the
> patches, but you get the idea.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
