[ 
https://issues.apache.org/jira/browse/HBASE-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243071#comment-16243071
 ] 

Appy commented on HBASE-18962:
------------------------------

Can't access RB right now (it keeps on loading), so posting quick comment here.

Single unit test should never test multiple code paths simultaneously. See how 
the current test is trying to test success case and failure cases both in same 
test, and how it was *needed* to order them in that particular order otherwise 
it wouldn't have worked. Please isolate them in different tests.
And when middle one is in separate test, you won't need separate thread for 
region.batchMutate() since unexpected exceptions fail the test.

> Support atomic BatchOperations through batchMutate()
> ----------------------------------------------------
>
>                 Key: HBASE-18962
>                 URL: https://issues.apache.org/jira/browse/HBASE-18962
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0-alpha-3
>            Reporter: Umesh Agashe
>            Assignee: Umesh Agashe
>             Fix For: 2.0.0-beta-1
>
>         Attachments: hbase-18962.master.001.patch
>
>
> Support all mutations in BatchOperations to be applied atomically (all or 
> none) by locking all rows corresponding to mutations exclusively.
> mutateRows() which uses MultiRowMutationProcessor applies all mutations 
> atomically and batchMutate() is non-atomic. To unify code paths, isAtomic() 
> attribute can be added to BatchOperations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to