[
https://issues.apache.org/jira/browse/HBASE-19229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246352#comment-16246352
]
Sean Busbey commented on HBASE-19229:
-------------------------------------
Example:
{code}
Busbey-MBA:hbase busbey$ mvn -DskipTests -pl hbase-client -am package >/dev/null
Busbey-MBA:hbase busbey$ ./dev-support/hbase_nightly_source-artifact.sh .
You'll find logs and temp files in /tmp/hbase-srctarball-test-28658.10317
Maven details, in case our JDK doesn't match expectations:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T14:39:06-05:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_74, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
Do a clean building of the source artifact using code in
/Users/busbey/tmp_projects/hbase/.
Follow the ref guide section on making a RC: Step 6 Build the source tarball
Unpack the source tarball
Diff against source tree
Checking against things we don't expect to include in the source tarball (git
related, etc.)
Any output here are unexpected differences between the source artifact we'd
make for an RC and the current branch.
One potential source of differences is if you have an unclean working
directory; you should expect to see
such extraneous files below.
The expected differences are on the < side and the current differences are on
the > side.
In a given set of differences, '.' refers to the branch in the repo and
'unpacked_src_tarball' refers to what we pulled out of the tarball.
1a2,13
> Only in ./hbase-annotations: target
> Only in ./hbase-build-configuration: target
> Only in ./hbase-checkstyle: target
> Only in ./hbase-client: target
> Only in ./hbase-common: target
> Only in ./hbase-hadoop-compat: target
> Only in ./hbase-hadoop2-compat: target
> Only in ./hbase-metrics: target
> Only in ./hbase-metrics-api: target
> Only in ./hbase-protocol: target
> Only in ./hbase-protocol-shaded: target
> Only in .: target
Busbey-MBA:hbase busbey$ ./dev-support/hbase_nightly_source-artifact.sh
--clean-source-checkout .
You'll find logs and temp files in /tmp/hbase-srctarball-test-7218.2316
Maven details, in case our JDK doesn't match expectations:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T14:39:06-05:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_74, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_74.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
Do a clean building of the source artifact using code in
/Users/busbey/tmp_projects/hbase/.
Clean...
Follow the ref guide section on making a RC: Step 6 Build the source tarball
Unpack the source tarball
Diff against source tree
Checking against things we don't expect to include in the source tarball (git
related, etc.)
Everything looks as expected.
Follow the ref guide section on making a RC: Step 8 Build the binary tarball.
{code}
Instead of passing the flag, I could have cleaned the directory myself or could
just eyeball the local results and decide those entries don't matter.
> Nightly script to check source artifact should not do a destructive git
> operation without opt-in
> ------------------------------------------------------------------------------------------------
>
> Key: HBASE-19229
> URL: https://issues.apache.org/jira/browse/HBASE-19229
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Attachments: HBASE-19229.0.patch
>
>
> right now we have a "git please destroy all this stuff" command in the check
> of the source artifact. we shouldn't do this unless the person invoking the
> script has indicated that's okay (e..g through a cli flag).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
