[
https://issues.apache.org/jira/browse/HBASE-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-12350:
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: This change introduces compile time support for running the
error-prone suite of static analyses. Enable with -PerrorProne on the Maven
command line. Requires JDK 8 or higher. (Don't enable if building with JDK 7.)
Status: Resolved (was: Patch Available)
Attaching what I committed to branch-1 and branch-1.4. I had to put all
dependencies and activation under the errorProne profile so we can continue to
build releases with JDK 7. There are some classfiles >= v52 in the error-prone
tooling. Also needed to avoid a dependency cycle between the hbase-error-prone
module and the root module when the errorProne profile is active.
Tested with builds on JDK 8 with and without -PerrorProne.
Tested with a build on JDK 7 without -PerrorProne.
As followup I'll look at refactoring the duplicated errorProne profile to a
common location. I see how it was done for branch-2 and master but that doesn't
seem to work in branch-1. I can split things out into hbase-build-support and
hbase-build-configuration but then the profile activation doesn't work for some
reason.
> Backport error-prone build support to branch-1 and branch-2
> -----------------------------------------------------------
>
> Key: HBASE-12350
> URL: https://issues.apache.org/jira/browse/HBASE-12350
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-12350-branch-1.patch, HBASE-12350-branch-1.patch,
> HBASE-12350-branch-2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
