[ 
https://issues.apache.org/jira/browse/HBASE-19164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246996#comment-16246996
 ] 

Mike Drob commented on HBASE-19164:
-----------------------------------

bq. Shall i do "Submit Patch" to trigger the QA?
Yes, please.

Some specific patch feedback:

In {{IntegrationTestBigLinkedList}} I think we want to stick to real UUIDs for 
now, because we have to read them back later.
Same for {{IntegrationTestBigLinkedListWithVisibility}}.

ib {{TestRegionSplitCalculator}} please make sure the modifier order is 
{{public static final}}

> Avoid UUID.randomUUID in tests
> ------------------------------
>
>                 Key: HBASE-19164
>                 URL: https://issues.apache.org/jira/browse/HBASE-19164
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Mike Drob
>            Assignee: Sahil Aggarwal
>              Labels: beginner
>         Attachments: HBASE-19164.master.001.patch
>
>
> We have a lot of places in our test code where we use {{UUID.randomUUID}} to 
> generate table names or paths for uniqueness. Unfortunately, this uses up a 
> good chunk of system entropy, since Sun chose that random UUID's should use 
> the NativePRNGBlocking implementation.
> We don't need to block on entropy for random bits to pick a random table name 
> in a test, so we can use something that doesn't strain the system too much - 
> secure random can be a source of problems on some VM or containers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to