[
https://issues.apache.org/jira/browse/HBASE-14141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248714#comment-16248714
]
stack commented on HBASE-14141:
-------------------------------
This should have a release note.
Is this facility on always? The walToHfile? (If I just wanted to copy WALs
though it overcopying, it is no longer allowed?)
This looks generally useful... walToHFiles. Break it out?
What happens if convertion to hfiles fails midway? I don't see cleanup (perhaps
it is there -- in failBackup, but we don't seem to pass the tmp dir name.... I
see that incrementalCopyHFiles does cleanup... but don't see it in convertion
of WAL to hfile).
This commit has no test. How we know if it works or if it is broke subsequently?
bq. * Get list of WAL files eligible for incremental backup
What makes a WAL eliible for backup?
getLogFilesFromBackupSystem gets log files from backup table. Will this be a
large set. Does Will the set be large? Will it grow w/o bound?
Why do operators sometimes have spaces around them and then in same line, they
do not: "180 for (int i=0; i < logFromSystemTable.size(); i++) {"
> HBase Backup/Restore Phase 3: Filter WALs on backup to include only edits
> from backed up tables
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-14141
> URL: https://issues.apache.org/jira/browse/HBASE-14141
> Project: HBase
> Issue Type: New Feature
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-14141.HBASE-14123.v1.patch, HBASE-14141.v1.patch,
> HBASE-14141.v2.patch, HBASE-14141.v4.patch, HBASE-14141.v5.patch,
> HBASE-14141.v6.patch
>
>
> h2. High level design overview
> * When incremental backup request comes for tables {t} we select all the
> tables already registered in a backup system - {T} and union them with {t},
> which results in a new table set - U(t, T)
> * For every table K from U(t,T) we perform the following:
> ** Convert new WAL files into HFile applying table filter K (only edits for
> table T will pass the filter)
> ** Move these HFile(s) to backup destination
> During restore (incremental):
> * We run full restore first
> * Then collect all HFiles from intermediate incremental images and run them
> through HFileSplitterJob, which splits files into a current tables region
> boundaries
> * Load these files using LoadIncrementalHFiles tool
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
