[
https://issues.apache.org/jira/browse/HBASE-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249937#comment-16249937
]
Andrew Purtell edited comment on HBASE-19232 at 11/13/17 6:28 PM:
------------------------------------------------------------------
bq. As for testing, [YCSB|https://github.com/brianfrankcooper/YCSB] has a
storage module, {{hbase12}}, that relies on the shaded client. You could see
that that still works if you swap in the 1.4 shaded client.
With YCSB I'm pretty sure it will work. The implicated classes are a possible
dependency for the YARN client. Only a MapReduce application would be impacted.
However elsewhere I was asked to do a performance comparison between a 1.4 RC
and earlier released versions. I can therefore achieve two objectives by doing
this. :-)
was (Author: apurtell):
bq. As for testing, [YCSB|https://github.com/brianfrankcooper/YCSB] has a
storage module, {{hbase12}}, that relies on the shaded client. You could see
that that still works if you swap in the 1.4 shaded client.
With YCSB I'm pretty sure it will work. The implicated classes are a possible
dependency for YARN. Only a MapReduce application would be impacted. However
elsewhere I was asked to do a performance comparison between a 1.4 RC and
earlier released versions. I can therefore achieve two objectives by doing
this. :-)
> Fix shaded-check-invariants (check-jar-contents) failure on branch-1
> --------------------------------------------------------------------
>
> Key: HBASE-19232
> URL: https://issues.apache.org/jira/browse/HBASE-19232
> Project: HBase
> Issue Type: Task
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: HBASE-19232-branch-1.patch
>
>
> Jersey API and client jars shaded into client jar.
> {noformat}
> [ERROR] Found artifact with unexpected contents:
> '/Users/apurtell/src/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-1.5.0-SNAPSHOT.jar'
> Please check the following and either correct the build or update
> the allowed list with reasoning.
> com/
> com/sun/
> com/sun/jersey/
> com/sun/jersey/api/
> com/sun/jersey/api/client/
> com/sun/jersey/api/client/AbstractClientRequestAdapter.class
> com/sun/jersey/api/client/AsyncUniformInterface.class
> com/sun/jersey/api/client/AsyncViewResource$1.class
> com/sun/jersey/api/client/AsyncViewResource$2.class
> com/sun/jersey/api/client/AsyncViewResource$Builder.class
> com/sun/jersey/api/client/AsyncViewResource.class
> com/sun/jersey/api/client/AsyncViewUniformInterface.class
> com/sun/jersey/api/client/AsyncWebResource$1.class
> com/sun/jersey/api/client/AsyncWebResource$2.class
> com/sun/jersey/api/client/AsyncWebResource$3.class
> com/sun/jersey/api/client/AsyncWebResource$4.class
> com/sun/jersey/api/client/AsyncWebResource$5.class
> com/sun/jersey/api/client/AsyncWebResource$6.class
> com/sun/jersey/api/client/AsyncWebResource$Builder.class
> com/sun/jersey/api/client/AsyncWebResource.class
> com/sun/jersey/api/client/Client$1.class
> com/sun/jersey/api/client/Client$2.class
> com/sun/jersey/api/client/Client$3.class
> com/sun/jersey/api/client/Client$4$1.class
> com/sun/jersey/api/client/Client$4.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl$1.class
> com/sun/jersey/api/client/Client$ComponentProcessorFactoryImpl.class
> com/sun/jersey/api/client/Client$ContextInjectableProvider.class
> com/sun/jersey/api/client/Client.class
> com/sun/jersey/api/client/ClientHandler.class
> com/sun/jersey/api/client/ClientHandlerException.class
> com/sun/jersey/api/client/ClientRequest$Builder.class
> com/sun/jersey/api/client/ClientRequest.class
> com/sun/jersey/api/client/ClientRequestAdapter.class
> com/sun/jersey/api/client/ClientResponse$Status.class
> com/sun/jersey/api/client/ClientResponse.class
> com/sun/jersey/api/client/CommittingOutputStream.class
> com/sun/jersey/api/client/ComponentsClientConfig.class
> com/sun/jersey/api/client/GenericType.class
> com/sun/jersey/api/client/PartialRequestBuilder.class
> com/sun/jersey/api/client/RequestBuilder.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriter.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterImpl.class
> com/sun/jersey/api/client/RequestWriter$RequestEntityWriterListener.class
> com/sun/jersey/api/client/RequestWriter.class
> com/sun/jersey/api/client/TerminatingClientHandler.class
> com/sun/jersey/api/client/UniformInterface.class
> com/sun/jersey/api/client/UniformInterfaceException.class
> com/sun/jersey/api/client/ViewResource$1.class
> com/sun/jersey/api/client/ViewResource$Builder.class
> com/sun/jersey/api/client/ViewResource.class
> com/sun/jersey/api/client/ViewUniformInterface.class
> com/sun/jersey/api/client/WebResource$1.class
> com/sun/jersey/api/client/WebResource$Builder.class
> com/sun/jersey/api/client/WebResource.class
> com/sun/jersey/api/client/WebResourceLinkHeaders.class
> com/sun/jersey/api/client/async/
> com/sun/jersey/api/client/async/AsyncClientHandler.class
> com/sun/jersey/api/client/async/FutureListener.class
> com/sun/jersey/api/client/async/ITypeListener.class
> com/sun/jersey/api/client/async/TypeListener.class
> com/sun/jersey/api/client/config/
> com/sun/jersey/api/client/config/ClientConfig.class
> com/sun/jersey/api/client/config/DefaultClientConfig.class
> com/sun/jersey/api/client/filter/
> com/sun/jersey/api/client/filter/ClientFilter.class
> com/sun/jersey/api/client/filter/ClientRequestContainer.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter$Adapter.class
> com/sun/jersey/api/client/filter/ConnectionListenerFilter.class
> com/sun/jersey/api/client/filter/ContainerListener.class
> com/sun/jersey/api/client/filter/CsrfProtectionFilter.class
> com/sun/jersey/api/client/filter/Filterable.class
> com/sun/jersey/api/client/filter/GZIPContentEncodingFilter$Adapter.class
> com/sun/jersey/api/client/filter/GZIPContentEncodingFilter.class
> com/sun/jersey/api/client/filter/HTTPBasicAuthFilter.class
> com/sun/jersey/api/client/filter/HTTPDigestAuthFilter$1.class
> com/sun/jersey/api/client/filter/HTTPDigestAuthFilter$QOP.class
> com/sun/jersey/api/client/filter/HTTPDigestAuthFilter$State.class
> com/sun/jersey/api/client/filter/HTTPDigestAuthFilter.class
> com/sun/jersey/api/client/filter/LoggingFilter$Adapter.class
> com/sun/jersey/api/client/filter/LoggingFilter$LoggingOutputStream.class
> com/sun/jersey/api/client/filter/LoggingFilter.class
> com/sun/jersey/api/client/filter/OnStartConnectionListener.class
> com/sun/jersey/api/client/filter/ReportingInputStream.class
> com/sun/jersey/api/client/filter/ReportingOutputStream.class
> com/sun/jersey/client/
> com/sun/jersey/client/impl/
> com/sun/jersey/client/impl/ClientRequestImpl.class
> com/sun/jersey/client/impl/CopyOnWriteHashMap.class
> com/sun/jersey/client/impl/async/
> com/sun/jersey/client/impl/async/FutureClientResponseListener$1.class
> com/sun/jersey/client/impl/async/FutureClientResponseListener.class
> com/sun/jersey/client/osgi/
> com/sun/jersey/client/osgi/Activator.class
> com/sun/jersey/client/proxy/
> com/sun/jersey/client/proxy/ViewProxy.class
> com/sun/jersey/client/proxy/ViewProxyProvider.class
> com/sun/jersey/client/urlconnection/
> com/sun/jersey/client/urlconnection/HTTPSProperties.class
> com/sun/jersey/client/urlconnection/HttpURLConnectionFactory.class
> com/sun/jersey/client/urlconnection/URLConnectionClientHandler$1$1.class
> com/sun/jersey/client/urlconnection/URLConnectionClientHandler$1.class
>
> com/sun/jersey/client/urlconnection/URLConnectionClientHandler$URLConnectionResponse.class
> com/sun/jersey/client/urlconnection/URLConnectionClientHandler.class
> com/sun/ws/
> com/sun/ws/rs/
> com/sun/ws/rs/ext/
> com/sun/ws/rs/ext/RuntimeDelegateImpl.class
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
