[ 
https://issues.apache.org/jira/browse/HBASE-19253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251261#comment-16251261
 ] 

Ted Yu commented on HBASE-19253:
--------------------------------

{code}
77        public final static String FLUSHER_THREADS_MAX = 
"hbase.hstore.flusher.count.max";
78        public final static int FLUSHER_THREADS_MAX_DEFAULT = 8;
{code}
How is the max determined ?
{code}
+          if (id >= handlerCount) {
+            Thread.sleep(1000);
+            continue;
+          }
{code}
When would the if block be executed ? It seems once the sleep is executed, 
subsequent iterations would always sleep.
{code}
+  protected int getFlusherThreadNum() {
+    return handlerCount;
{code}
getFlusherThreadNum -> getFlusherThreadCount
{code}
+      newHandlerCount = 1;
+    }
+    if (newHandlerCount > maxHandlerCount) {
{code}
The second if can be 'else if'

> Dynamic change MemStoreFlusher FlushHandler workers
> ---------------------------------------------------
>
>                 Key: HBASE-19253
>                 URL: https://issues.apache.org/jira/browse/HBASE-19253
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>         Attachments: HBASE-19253.master.001.patch
>
>
> Use update_config to dynamic change MemStoreFlusher FlushHandler workers



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to