[
https://issues.apache.org/jira/browse/HBASE-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192440#comment-13192440
]
stack commented on HBASE-5231:
------------------------------
In a method named getAssignmentsByTable we will return regions by table IFF a
configuration hbase.master.loadbalance.bytable is true. Otherwise we return
all regions belonging to a 'table' named 'ensemble'. No where is 'ensemble'
explained. How is a noob who follows along after us trying to make sense of
this supposed to figure whats going on? A method named getAssignmentsByTable
should return assignments by table... not assignments by table and then if some
flag in config. is set, assignments by some arbitrary pseudo table. At a
minimum it needs to be explained by comments and in javadoc. But really it
says to me that this new feature is not well thought through. Why do we worry
about regions by table outside of the balancer invocation; shouldn't the
balancer-by-table being asking about a regions table down in the balancer guts
rather than up here high in the master.
Looking more at what is going on, when the balance finishes, do we have a
balanced cluster? There is no test to prove it and thinking on it, given as we
invoke the balancer per table, if lots of tables with different region count
skew, I'd think it could throw off the basic cluster balance (regions per
regionserver).
> Backport HBASE-3373 (per-table load balancing) to 0.92
> ------------------------------------------------------
>
> Key: HBASE-5231
> URL: https://issues.apache.org/jira/browse/HBASE-5231
> Project: HBase
> Issue Type: Improvement
> Reporter: Zhihong Yu
> Fix For: 0.92.1
>
> Attachments: 5231-v2.txt, 5231.txt
>
>
> This JIRA backports per-table load balancing to 0.90
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
