[
https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253052#comment-16253052
]
Reid Chan edited comment on HBASE-19262 at 11/15/17 7:29 AM:
-------------------------------------------------------------
bq. For the shaded imports, I prefer we put it at the bottom with a separated
block.
Agree. Old version of check-style was as your description, code base is mixed
with two styles now.
was (Author: reidchan):
bq. For the shaded imports, I prefer we put it at the bottom with a separated
block.
Agree. Old version of check-style is as your description, code base is mixed
with two styles now.
> Revisit checkstyle rules
> ------------------------
>
> Key: HBASE-19262
> URL: https://issues.apache.org/jira/browse/HBASE-19262
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Duo Zhang
>
> For the shaded imports, I prefer we put it at the bottom with a separated
> block. And also, for UTs which use junit rule, we usually declare the field
> as public but checkstyle will report a VisibilityModifier problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
