[
https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-19262:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-beta-1
1.2.7
1.5.0
1.3.2
1.4.0
3.0.0
Release Note: Change the import order rule that now we should put the
shaded import at bottom. Ignore the VisibilityModifier warnings for test code.
Status: Resolved (was: Patch Available)
Pushed to branch-1.2+.
Thanks all for reviewing.
> Revisit checkstyle rules
> ------------------------
>
> Key: HBASE-19262
> URL: https://issues.apache.org/jira/browse/HBASE-19262
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-beta-1
>
> Attachments: HBASE-19262.patch, idea_import_layout.png
>
>
> For the shaded imports, I prefer we put it at the bottom with a separated
> block. And also, for UTs which use junit rule, we usually declare the field
> as public but checkstyle will report a VisibilityModifier problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
