[
https://issues.apache.org/jira/browse/HBASE-17852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256071#comment-16256071
]
stack commented on HBASE-17852:
-------------------------------
Looking at patch...
Why log two debug lines, one after the other? Logs should be terse. Two lines
not needed.
149 LOG.debug("Added region procedure manager: " +
regionProcedureClass);
150 LOG.debug("Added region observer: " + regionObserverClass);
bq. The issue with a single table (backup:system) arises from that fact that we
have multiple independent writers: backup client application and BackupObserver
(on each RS). In case of a backup failure we perform table rollback (restore
from snapshot), which can result in a loss of data being written by
BackupObserver(s), that is why I introduced separate table to keep track of
bulk loaded files.
I don't understand the above. There is a backup failure, so we restore a
snapshot? And an Observer can lose data? And so we introduce a new table just
to hold bulk loaded files? I don't get it.
Looking at comment on the back up bulkLoadTableName data member.... It says
"... * We keep all bulk loaded file references in a separate table
127 * because we have to isolate general backup operations: create,
merge etc
128 * from activity of RegionObserver, which controls process of a bulk
loading
129 * {@link org.apache.hadoop.hbase.backup.BackupObserver}"
How do general backup ops and bulk loaded files effect each other?
In the patch, it is called a ' Backup System table name for bulk loaded files'
... but it is not a system table? Is that so? And this is different from the
BackupSystemTable.... which also is not a system table, right?
BackupSystemTable does a checkSystemTable(); It is checking system tables, or
not?
In hbase2, we have builders for the below instead...
1381 HTableDescriptor tableDesc = new
HTableDescriptor(getTableNameForBulkLoadedData(conf));
> Add Fault tolerance to HBASE-14417 (Support bulk loaded files in incremental
> backup)
> ------------------------------------------------------------------------------------
>
> Key: HBASE-17852
> URL: https://issues.apache.org/jira/browse/HBASE-17852
> Project: HBase
> Issue Type: Sub-task
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-17852-v1.patch, HBASE-17852-v2.patch,
> HBASE-17852-v3.patch, HBASE-17852-v4.patch, HBASE-17852-v5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
