[
https://issues.apache.org/jira/browse/HBASE-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256087#comment-16256087
]
Andrew Purtell commented on HBASE-19239:
----------------------------------------
bq. TestProcedureInMemoryChore.java: boolean result is unused? Same for
TestClientPushback.java
Yep these in effect turn off findbugs "return value ignored" warnings. It's a
trade of one type of warning for another (findbugs to eclipse/checkstyle). We
didn't use the result before so no harm. Or I can leave these alone so we
continue to see them as findbugs issues.
bq. In lots of places, I've heard that using StandardCharsets.UTF_8 is 15%
slower
You mean instead of just strings of "UTF-8"? I'd prefer to keep the constants.
bq. RpcServer.java: why not start = rand.nextInt(numConnections)?
bq. similar for TestFastFail.java
Ok
bq. I'd like to request that you follow like you did on github and commit each
module separately.
Yeah I can do that. I've kept a sequence of per module commits in a local
working branch. See
https://github.com/apurtell/hbase/commits/HBASE-19239-branch-1
> Fix findbugs and error-prone warnings
> -------------------------------------
>
> Key: HBASE-19239
> URL: https://issues.apache.org/jira/browse/HBASE-19239
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 3.0.0, 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19239-branch-1.patch
>
>
> Fix important findbugs and error-prone warnings on branch-1.4 / branch-1.
> Forward port as appropriate.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
