[ 
https://issues.apache.org/jira/browse/HBASE-19290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256632#comment-16256632
 ] 

Appy commented on HBASE-19290:
------------------------------

- Please add a short commit message explaining 'idea' of the change (makes 
reviewing easy then having to reverse engineer the 'idea')
- grabTask only returns 0 or 1. Use boolean please.
- Add @return comment to grabTask.
- We probably don't need {{if (taskGrabed == 0 && !shouldStop) }}, 
taskReadySeq.wait is indefinite wait on availability of next task.
- Can we pull the while loop one level outside and share the 
{{if(calculateAvailableSplitters(..))}} condition.

> Reduce zk request when doing split log
> --------------------------------------
>
>                 Key: HBASE-19290
>                 URL: https://issues.apache.org/jira/browse/HBASE-19290
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>            Assignee: binlijin
>         Attachments: HBASE-19290.master.001.patch
>
>
> We observe once the cluster has 1000+ nodes and when hundreds of nodes abort 
> and doing split log, the split is very very slow, and we find the 
> regionserver and master wait on the zookeeper response, so we need to reduce 
> zookeeper request and pressure for big cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to